feat(oidc): add discovery_url override and claims_mapping for OIDC pr… - #6233
feat(oidc): add discovery_url override and claims_mapping for OIDC pr…#6233montaro wants to merge 2 commits into
Conversation
|
👋 Hi @montaro! Thanks for your contribution to this project. It looks like one or more of your commits are missing a DCO (Developer Certificate of Origin) sign-off. The DCO is a simple way for you to certify that you have the right to submit this code under the project's license. How to fix this: # For future commits, use the -s flag
git commit -s -m "Your commit message"
# To sign off on existing commits in this PR
git rebase HEAD~$(git rev-list --count origin/v2..HEAD) --signoff
git push --force-with-leaseThe 📋 View the failing DCO check for more details For more information about the DCO, visit: https://developercertificate.org/ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: approve
Clean, well-tested auth change. The discovery_url override correctly uses go-oidc's InsecureIssuerURLContext while pinning token verification to issuer_url, and claims_mapping handles arrays, missing values, and non-strings properly. No code issues found. (Note: the PR is still marked [WIP] and the DCO check is failing — commits need sign-offs.)
🤖 Automated review by the Flipt PR review agent.
It moves from parsing JSON pointer expressions on every applyMapping call to compiling them once in newClaimsMapping during newOIDCClient, with config-time validation and debug logging for resolution failures. Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
65b7ab4 to
2b76f70
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #6233 +/- ##
==========================================
+ Coverage 62.41% 62.45% +0.04%
==========================================
Files 145 145
Lines 14867 14910 +43
==========================================
+ Hits 9279 9312 +33
- Misses 4828 4836 +8
- Partials 760 762 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
…oviders [WIP]